app.bettersight.io/backend/tests/test_api_extended.py

"""
Additional route coverage beyond tests/test_api.py's core happy-path
set — account management, billing, internal (n8n) routes, and the
Stripe webhook signature-verification path.
"""
import sys
import types
import pytest
from repositories.tenant_repository import tenant_repository
from repositories.seat_repository import seat_repository
from repositories.competitor_repository import competitor_repository
from repositories.scrape_repository import scrape_repository
from repositories.battlecard_repository import battlecard_repository
from repositories.comparable_repository import comparable_repository


def _make_tenant(**overrides):
    data = {
        'name': 'G Adventures', 'email': 'pm@gadventures.com', 'domain': 'gadventures.com',
        'tier': 'analyse', 'status': 'active', 'max_seats': 5,
        'onboarding_checklist': {'add_competitor': False, 'tour_step': 0},
    }
    data.update(overrides)
    return tenant_repository.create(data)


def _install_fake_module(monkeypatch, dotted_name, **attrs):
    parts = dotted_name.split('.')
    for i in range(1, len(parts) + 1):
        partial = '.'.join(parts[:i])
        if partial not in sys.modules:
            monkeypatch.setitem(sys.modules, partial, types.ModuleType(partial))
    for key, value in attrs.items():
        setattr(sys.modules[dotted_name], key, value)


# ── Account ────────────────────────────────────────────────────────

def test_get_account_returns_tenant_with_seats(client, api_headers):
    tenant = _make_tenant()
    seat_repository.create({'tenant_id': tenant['id'], 'email': 'pm@gadventures.com', 'active': True})

    response = client.get(f'/account/{tenant["id"]}', headers=api_headers)

    assert response.status_code == 200
    assert response.json['name'] == 'G Adventures'
    assert len(response.json['seats']) == 1


def test_get_account_unknown_tenant_404(client, api_headers):
    response = client.get('/account/does-not-exist', headers=api_headers)
    assert response.status_code == 404


def test_update_competitor(client, api_headers):
    tenant = _make_tenant()
    competitor = competitor_repository.create({
        'tenant_id': tenant['id'], 'name': 'Intrepid', 'website': 'https://intrepidtravel.com',
        'catalogue_url': 'https://intrepidtravel.com/adventures', 'primary_market': 'GB', 'active': True,
    })

    response = client.put(
        f'/account/competitors/{competitor["id"]}', json={'primary_market': 'US'}, headers=api_headers
    )

    assert response.status_code == 200
    assert response.json['primary_market'] == 'US'


def test_update_unknown_competitor_404(client, api_headers):
    response = client.put('/account/competitors/nope', json={}, headers=api_headers)
    assert response.status_code == 404


def test_delete_competitor_deactivates_and_deregisters(client, api_headers, monkeypatch):
    tenant = _make_tenant()
    competitor = competitor_repository.create({
        'tenant_id': tenant['id'], 'name': 'Intrepid', 'website': 'https://intrepidtravel.com',
        'catalogue_url': 'https://intrepidtravel.com/adventures', 'primary_market': 'GB',
        'active': True, 'firecrawl_monitor_id': 'mon_123',
    })
    deregistered = []
    monkeypatch.setattr('api.requests.delete', lambda url, timeout: deregistered.append(url))

    response = client.delete(f'/account/competitors/{competitor["id"]}', headers=api_headers)

    assert response.status_code == 200
    assert competitor_repository.get_by_id(competitor['id'])['active'] is False
    assert deregistered


def test_delete_unknown_competitor_404(client, api_headers):
    response = client.delete('/account/competitors/nope', headers=api_headers)
    assert response.status_code == 404


def test_account_template_returns_static_link(client, api_headers):
    response = client.get('/account/template', headers=api_headers)
    assert response.status_code == 200
    assert 'template_url' in response.json


def test_onboarding_patch_requires_resolvable_session(client, api_headers):
    response = client.patch('/account/onboarding', json={'tour_step': 2}, headers=api_headers)
    assert response.status_code == 401


def test_onboarding_patch_updates_checklist(client, api_headers, monkeypatch):
    tenant = _make_tenant()
    monkeypatch.setattr('api.auth_service.get_tenant_id_from_request', lambda req: tenant['id'])

    response = client.patch(
        '/account/onboarding', json={'tour_step': 2},
        headers={**api_headers, 'Authorization': 'Bearer sometoken'}
    )

    assert response.status_code == 200
    assert response.json['onboarding_checklist']['tour_step'] == 2


def test_delete_account_requires_tenant_id(client, api_headers):
    response = client.post('/account/delete', json={}, headers=api_headers)
    assert response.status_code == 400


def test_delete_account_marks_inactive_and_deactivates_competitors(client, api_headers):
    tenant = _make_tenant()
    competitor = competitor_repository.create({
        'tenant_id': tenant['id'], 'name': 'Intrepid', 'website': 'https://intrepidtravel.com',
        'catalogue_url': 'https://intrepidtravel.com/adventures', 'primary_market': 'GB', 'active': True,
    })
    seat_repository.create({'tenant_id': tenant['id'], 'email': 'pm@gadventures.com', 'active': True})

    response = client.post('/account/delete', json={'tenant_id': tenant['id']}, headers=api_headers)

    assert response.status_code == 200
    assert tenant_repository.get_by_id(tenant['id'])['status'] == 'inactive'
    assert competitor_repository.get_by_id(competitor['id'])['active'] is False
    assert seat_repository.list_for_tenant(tenant['id']) == []


# ── Billing ────────────────────────────────────────────────────────

def test_billing_portal_requires_session(client, api_headers):
    response = client.get('/billing/portal', headers=api_headers)
    assert response.status_code == 401


def test_billing_portal_no_stripe_customer_returns_400(client, api_headers, monkeypatch):
    tenant = _make_tenant()
    monkeypatch.setattr('api.auth_service.get_tenant_id_from_request', lambda req: tenant['id'])

    response = client.get(
        '/billing/portal', headers={**api_headers, 'Authorization': 'Bearer x'}
    )
    assert response.status_code == 400
    assert response.json['code'] == 'no_stripe_customer'


def test_billing_upgrade_requires_fields(client, api_headers):
    response = client.post('/billing/upgrade', json={}, headers=api_headers)
    assert response.status_code == 400


def test_billing_upgrade_unconfigured_tier_returns_400(client, api_headers):
    tenant = _make_tenant()
    response = client.post(
        '/billing/upgrade', json={'tenant_id': tenant['id'], 'target_tier': 'discover'}, headers=api_headers
    )
    assert response.status_code == 400
    assert response.json['code'] == 'upgrade_failed'


# ── Internal (n8n) ─────────────────────────────────────────────────

def test_internal_battlecard_requires_tenant_id(client, api_headers):
    response = client.post('/internal/battlecard/c1', json={}, headers=api_headers)
    assert response.status_code == 400


def test_internal_battlecard_generates_card(client, api_headers, monkeypatch):
    tenant = _make_tenant()
    competitor = competitor_repository.create({
        'tenant_id': tenant['id'], 'name': 'Intrepid', 'website': 'https://intrepidtravel.com',
        'catalogue_url': 'https://intrepidtravel.com/adventures', 'primary_market': 'GB', 'active': True,
    })
    _install_fake_module(
        monkeypatch, 'core.extractor',
        extract_with_openrouter=lambda prompt, content: {
            'positioning': 'x', 'strengths': [], 'weaknesses': [], 'pricing_observation': 'y'
        }
    )

    response = client.post(
        f'/internal/battlecard/{competitor["id"]}', json={'tenant_id': tenant['id']}, headers=api_headers
    )

    assert response.status_code == 200
    assert response.json['content_json']['positioning'] == 'x'


def test_internal_weekly_brief(client, api_headers, monkeypatch):
    called = []
    monkeypatch.setattr('api.brief_service.send_weekly_brief', lambda tenant_id: called.append(tenant_id))
    response = client.post('/internal/weekly-brief/t1', headers=api_headers)
    assert response.status_code == 200
    assert called == ['t1']


def test_internal_monitor_webhook_flags_competitor(client, api_headers):
    tenant = _make_tenant()
    competitor = competitor_repository.create({
        'tenant_id': tenant['id'], 'name': 'Intrepid', 'website': 'https://intrepidtravel.com',
        'catalogue_url': 'https://intrepidtravel.com/adventures', 'primary_market': 'GB', 'active': True,
    })

    response = client.post(
        '/internal/monitor-webhook', json={'url': 'https://intrepidtravel.com'}, headers=api_headers
    )

    assert response.status_code == 200
    assert competitor_repository.get_by_id(competitor['id'])['change_detected'] is True


def test_internal_monitor_webhook_unknown_url_is_noop(client, api_headers):
    response = client.post(
        '/internal/monitor-webhook', json={'url': 'https://unknown.com'}, headers=api_headers
    )
    assert response.status_code == 200


def test_internal_monitor_register_and_deregister(client, api_headers, monkeypatch):
    tenant = _make_tenant()
    competitor = competitor_repository.create({
        'tenant_id': tenant['id'], 'name': 'Intrepid', 'website': 'https://intrepidtravel.com',
        'catalogue_url': 'https://intrepidtravel.com/adventures', 'primary_market': 'GB',
        'active': True, 'firecrawl_monitor_id': 'mon_1',
    })
    monkeypatch.setattr('api.requests.post', lambda *a, **k: types.SimpleNamespace(json=lambda: {'id': 'mon_2'}))
    monkeypatch.setattr('api.requests.delete', lambda *a, **k: None)

    r1 = client.post(f'/internal/monitor/register/{competitor["id"]}', headers=api_headers)
    assert r1.status_code == 200

    r2 = client.post(f'/internal/monitor/deregister/{competitor["id"]}', headers=api_headers)
    assert r2.status_code == 200


def test_internal_monitor_register_unknown_competitor_404(client, api_headers):
    response = client.post('/internal/monitor/register/nope', headers=api_headers)
    assert response.status_code == 404


def test_internal_scrape_enqueues_job(client, api_headers, monkeypatch):
    import jobs
    tenant = _make_tenant()
    captured = {}
    monkeypatch.setattr(jobs, 'enqueue_research_job', lambda job_id, data: captured.update(job_id=job_id))

    response = client.post(f'/internal/scrape/{tenant["id"]}', json={'competitors': []}, headers=api_headers)

    assert response.status_code == 200
    assert response.json['job_id'] == captured['job_id']


def test_internal_embed_products(client, api_headers, monkeypatch):
    from repositories.product_repository import product_repository
    tenant = _make_tenant()
    competitor = competitor_repository.create({
        'tenant_id': tenant['id'], 'name': 'Intrepid', 'website': 'https://intrepidtravel.com',
        'catalogue_url': 'https://intrepidtravel.com/adventures', 'primary_market': 'GB', 'active': True,
    })
    product_repository.create({
        'tenant_id': tenant['id'], 'competitor_id': competitor['id'], 'trip_name': 'Peru Classic',
    })
    monkeypatch.setattr('services.embedding_service.embed_trip', lambda trip: [0.1, 0.2])

    response = client.post(f'/internal/embed-products/{tenant["id"]}', headers=api_headers)

    assert response.status_code == 200
    assert response.json['embedded'] == 1


def test_internal_match_comparable(client, api_headers, monkeypatch):
    tenant = _make_tenant()
    monkeypatch.setattr(
        'services.embedding_service.find_comparable_trips',
        lambda client_trips, competitor_trips, threshold=0.75: [
            {'client_product': 'x', 'competitor_product': 'p1', 'similarity_score': 0.9,
             'price_difference': 10, 'duration_difference': 0}
        ]
    )

    response = client.post(
        f'/internal/match-comparable/{tenant["id"]}', json={'client_trips': []}, headers=api_headers
    )

    assert response.status_code == 200
    assert response.json['matches_created'] == 1
    assert len(comparable_repository.list_for_tenant(tenant['id'])) == 1


# ── Sheet (Phase 4 dependency — expect structured 501) ─────────────

def test_sheet_push_returns_not_yet_available(client, api_headers):
    tenant = _make_tenant()
    run = scrape_repository.create({
        'tenant_id': tenant['id'], 'triggered_by': 'manual', 'status': 'complete',
        'competitors_total': 0, 'competitors_done': 0, 'results': {},
    })
    response = client.post(
        '/sheet/push', json={'email': 'pm@gadventures.com', 'job_id': run['id'], 'tab_name': 'x'},
        headers=api_headers
    )
    assert response.status_code == 501


def test_sheet_tabs_returns_not_yet_available(client, api_headers):
    _make_tenant()
    response = client.get('/sheet/tabs', headers={**api_headers, 'X-User-Email': 'pm@gadventures.com'})
    assert response.status_code == 501


# ── Research history / status / battlecards / comparable-trips ────

def test_research_status_unknown_job_404(client, api_headers):
    response = client.get('/research/status/nope', headers=api_headers)
    assert response.status_code == 404


def test_research_status_known_job(client, api_headers):
    tenant = _make_tenant()
    run = scrape_repository.create({
        'tenant_id': tenant['id'], 'triggered_by': 'manual', 'status': 'running',
        'competitors_total': 2, 'competitors_done': 1, 'results': {},
    })
    response = client.get(f'/research/status/{run["id"]}', headers=api_headers)
    assert response.status_code == 200
    assert response.json['progress'] == {'total': 2, 'done': 1}


def test_research_history_detail_unknown_404(client, api_headers):
    response = client.get('/research/history/nope', headers=api_headers)
    assert response.status_code == 404


def test_research_history_for_tenant(client, api_headers):
    tenant = _make_tenant()
    scrape_repository.create({
        'tenant_id': tenant['id'], 'triggered_by': 'manual', 'status': 'complete',
        'competitors_total': 1, 'competitors_done': 1, 'results': {},
    })
    response = client.get('/research/history', query_string={'email': 'pm@gadventures.com'}, headers=api_headers)
    assert response.status_code == 200
    assert len(response.json) == 1


def test_battlecards_route(client, api_headers):
    tenant = _make_tenant()
    competitor = competitor_repository.create({
        'tenant_id': tenant['id'], 'name': 'Intrepid', 'website': 'https://intrepidtravel.com',
        'catalogue_url': 'https://intrepidtravel.com/adventures', 'primary_market': 'GB', 'active': True,
    })
    battlecard_repository.upsert(competitor['id'], {'tenant_id': tenant['id'], 'content': 'x', 'content_json': {}})

    response = client.post('/battlecards', json={'email': 'pm@gadventures.com'}, headers=api_headers)

    assert response.status_code == 200
    assert response.json[0]['competitor_name'] == 'Intrepid'


def test_comparable_trips_route(client, api_headers):
    tenant = _make_tenant()
    comparable_repository.create({'tenant_id': tenant['id'], 'client_product': 'x', 'similarity_score': 0.8})

    response = client.post('/comparable-trips', json={'email': 'pm@gadventures.com'}, headers=api_headers)

    assert response.status_code == 200
    assert len(response.json) == 1


def test_preview_prompt(client, api_headers, monkeypatch):
    _install_fake_module(
        monkeypatch, 'industries.adventure_travel.prompt',
        build_prompt=lambda *a, **k: 'a fake built prompt'
    )
    response = client.post('/preview-prompt', json={
        'productName': 'Inca Trail', 'destination': 'Peru', 'duration': 15, 'travelStyle': 'Classic',
    }, headers=api_headers)
    assert response.status_code == 200
    assert response.json['prompt'] == 'a fake built prompt'


# ── Auth password reset proxy routes ────────────────────────────────

def test_request_password_reset_missing_email(client, api_headers):
    response = client.post('/auth/request-password-reset', json={}, headers=api_headers)
    assert response.status_code == 400


def test_request_password_reset_ok(client, api_headers, monkeypatch):
    monkeypatch.setattr('api.requests.post', lambda *a, **k: types.SimpleNamespace(status_code=204))
    response = client.post(
        '/auth/request-password-reset', json={'email': 'pm@gadventures.com'}, headers=api_headers
    )
    assert response.status_code == 200


def test_confirm_password_reset_missing_fields(client, api_headers):
    response = client.post('/auth/confirm-password-reset', json={'token': 'x'}, headers=api_headers)
    assert response.status_code == 400


def test_confirm_password_reset_invalid_token(client, api_headers, monkeypatch):
    monkeypatch.setattr('api.requests.post', lambda *a, **k: types.SimpleNamespace(status_code=400))
    response = client.post('/auth/confirm-password-reset', json={
        'token': 'bad', 'password': 'newpass123', 'passwordConfirm': 'newpass123',
    }, headers=api_headers)
    assert response.status_code == 400
    assert response.json['code'] == 'reset_failed'


def test_confirm_password_reset_ok(client, api_headers, monkeypatch):
    monkeypatch.setattr('api.requests.post', lambda *a, **k: types.SimpleNamespace(status_code=200))
    response = client.post('/auth/confirm-password-reset', json={
        'token': 'good', 'password': 'newpass123', 'passwordConfirm': 'newpass123',
    }, headers=api_headers)
    assert response.status_code == 200


# ── Stripe webhook ──────────────────────────────────────────────────

def test_stripe_webhook_invalid_signature_rejected(client, monkeypatch):
    import stripe as stripe_module

    def _raise(*a, **k):
        raise ValueError('bad signature')

    monkeypatch.setattr(stripe_module.Webhook, 'construct_event', staticmethod(_raise))

    response = client.post(
        '/stripe/webhook', data=b'{}', headers={'Stripe-Signature': 'bad'}
    )
    assert response.status_code == 400
    assert response.json['code'] == 'invalid_signature'


def test_stripe_webhook_dispatches_checkout_completed(client, monkeypatch):
    import stripe as stripe_module
    tenant = _make_tenant()

    fake_event = {
        'type': 'checkout.session.completed',
        'data': {'object': {
            'metadata': {'tenant_id': tenant['id'], 'target_tier': 'discover'},
            'subscription': 'sub_1',
        }},
    }
    monkeypatch.setattr(stripe_module.Webhook, 'construct_event', staticmethod(lambda *a, **k: fake_event))

    response = client.post('/stripe/webhook', data=b'{}', headers={'Stripe-Signature': 'ok'})

    assert response.status_code == 200
    assert tenant_repository.get_by_id(tenant['id'])['tier'] == 'discover'


def test_stripe_webhook_dispatches_subscription_deleted(client, monkeypatch):
    import stripe as stripe_module
    tenant = _make_tenant(stripe_customer_id='cus_123')

    fake_event = {
        'type': 'customer.subscription.deleted',
        'data': {'object': {'customer': 'cus_123'}},
    }
    monkeypatch.setattr(stripe_module.Webhook, 'construct_event', staticmethod(lambda *a, **k: fake_event))

    response = client.post('/stripe/webhook', data=b'{}', headers={'Stripe-Signature': 'ok'})

    assert response.status_code == 200
    assert tenant_repository.get_by_id(tenant['id'])['status'] == 'inactive'


def test_stripe_webhook_unhandled_event_type_ok(client, monkeypatch):
    import stripe as stripe_module
    fake_event = {'type': 'invoice.paid', 'data': {'object': {}}}
    monkeypatch.setattr(stripe_module.Webhook, 'construct_event', staticmethod(lambda *a, **k: fake_event))

    response = client.post('/stripe/webhook', data=b'{}', headers={'Stripe-Signature': 'ok'})
    assert response.status_code == 200